ipc4: mixin/mixout cleanup after channel remapping mode been removed #8655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mute channel functionality was previously used as part of channel remapping feature. Since that feature was removed some time ago mute channel functionality is no longer used and is just a leftover from not fully completed cleanup. Signed-off-by: Serhiy Katsyuba <[email protected]>
Previously we had "normal" and "channel remapping" modes. Since channel remapping mode was removed, "normal" is the only supported mode, no need to prepend names with "normal". Signed-off-by: Serhiy Katsyuba <[email protected]>
Previously when channel remapping was supported processing was done iterating by frames. After channel remapping was removed processing was changed to iterate by samples, however, for some reason the code still uses confusing "frame" variables. Signed-off-by: Serhiy Katsyuba <[email protected]>
serhiy-katsyuba-intel
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
kv2019i
approved these changes
Dec 20, 2023
lgirdwood
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are cleanup commits extracted from PR #8537. That PR failed the CI (or maybe random fail?), more time to verify needed. Also these changed are not very related to sink/source API support in mixin/mixout, so having 2 smaller PR is better then 1 big.